Helper function to bind same random port multiple times in Netty #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #97 +/- ##
=========================================
Coverage 93.17% 93.18%
- Complexity 2019 2025 +6
=========================================
Files 134 134
Lines 4569 4575 +6
Branches 617 618 +1
=========================================
+ Hits 4257 4263 +6
Misses 171 171
Partials 141 141 ☔ View full report in Codecov by Sentry. |
szysas
force-pushed
the
multi-netty-random-port
branch
from
7e015d8
to
c22473b
Compare
akolosov-n
approved these changes
Aug 30, 2024
|
|
||
| // for random port update bootstrap with actual port but only if SO_REUSEPORT is enabled | ||
| if (bindToRandomPort() && reusePortIsEnabled()) { | ||
| bootstrap.localAddress(channel.localAddress()); |
There was a problem hiding this comment.
Does it work so, that after the first server using this bootstrap is started, then all the following server using the same bootstrap will use the updated version of it (with the port properly set)?
There was a problem hiding this comment.
Yes, exactly that way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.